Strange behaviour using replace

[ileitch]

Trying to replace a Text node with a Fragment (or anything else for that matter) results in some odd behaviour.

html = %q{blah http://google.com blah blah}
new_html = %q{blah <a href="http://google.com">http://google.com</a> blah blah}
frag = Nokogiri::HTML.fragment(html)
text = frag.children.first
p frag.to_html
text.replace(Nokogiri::HTML.fragment(new_html))
p "-" * 10
p frag.to_html

output:

"blah http://google.com blah blah"
"----------"
"<a href=\"http://google.com\">http://google.com</a>"

The "blah"s at the start and end are now missing.

ruby 1.8.6 (2009-06-08 patchlevel 369) [i686-darwin10.2.0]
nokogiri (1.4.2)
Snow Leopard 10.6.4

[flavorjones]

Reproduced. Will take a look.

[ileitch]

Hi, just tested this with 1.4.3.1 in 1.8.7 and 1.9.2 and the problem still exists.

I've tried using various approaches without success to work around this bug as I'd love to replace Hpricot with Nokogiri. Can you think of any way to work around this?

Cheers

[flavorjones]

XML::Node#{replace,add_previous_sibling,add_next_sibling} edge cases fixed related to libxml's text node merging. closed by 7540988

[flavorjones]

this is fixed in the branches '1.4' and 'master', and is targetted for 1.4.4.