Fix gcc warings - alternative to #2061 #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
../../../../ext/nokogiri/xml_document.c: In function ‘dealloc’:
../../../../ext/nokogiri/xml_document.c:58:25: warning: passing argument 2 of ‘rb_st_foreach’ from incompatible pointer type [-Wincompatible-pointer-types]
58 | st_foreach(node_hash, dealloc_node_i, (st_data_t)doc);
| ^~~~~~~~~~~~~~
| |
| int (*)(xmlNode *, xmlNode *, xmlDoc *) {aka int (*)(struct _xmlNode *, struct _xmlNode *, struct _xmlDoc *)}
|
Code Climate has analyzed commit 6c0af79 and detected 0 issues on this pull request. View more on Code Climate. |
|
I'm always cautious with casting function pointers. It disables all type checks and the compiler isn't aware about type casts for the values passed to and from the callback. @flavorjones Do you agree with me? |
|
✅ Build nokogiri 1.0.633 completed (commit c499f62dfb by @larskanis) |
|
@larskanis It builds successfully on Ruby build with Visual C++ and all tests pass (re-compiled my Ruby installation). Command Line Log from Compilation and Run of Test Suite |
preetpalS
reviewed
Aug 25, 2020
../../../../ext/nokogiri/xml_io.c: In function ‘io_read_callback’:
../../../../ext/nokogiri/xml_io.c:20:22: warning: passing argument 1 of ‘rb_rescue’ from incompatible pointer type [-Wincompatible-pointer-types]
20 | string = rb_rescue(read_check, (VALUE)args, read_failed, 0);
| ^~~~~~~~~~
| |
| VALUE (*)(VALUE *) {aka long unsigned int (*)(long unsigned int *)}
and
../../../../ext/nokogiri/xml_io.c:20:47: warning: passing argument 3 of ‘rb_rescue’ from incompatible pointer type [-Wincompatible-pointer-types]
20 | string = rb_rescue(read_check, (VALUE)args, read_failed, 0);
| ^~~~~~~~~~~
| |
| VALUE (*)(void) {aka long unsigned int (*)(void)}
larskanis
force-pushed
the
fix-gcc-warings
branch
from
0026e33
to
6c0af79
Compare
|
✅ Build nokogiri 1.0.634 completed (commit bcecb2f760 by @larskanis) |
|
I like this approach - will merge shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
GCC raises warnings for the function pointer mismatches and Visual-C raises errors in #2061 . Both should be fixed by this patch. In contrast to #2061 this patch ensures type safety for the single values to be passed to the callback.
Have you included adequate test coverage?
Visual-C is not tested.
Does this change affect the C or the Java implementations?
Only C.