Don't remove empty directories after build. #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deletion of these empty directories is flawed on docker with overlayfs, so we better avoid it. The build artifacts are still removed after gem install. This fixes nokogiri issue sparklemotion#1370 . For further details to the root issue see: moby/moby#19082
larskanis
added a commit
that referenced
this pull request
Jan 6, 2016
…layfs Don't remove empty directories after build.
|
Thanks for tracking this down. |
|
@flavorjones Would you consider publishing v1.6.7.3 that includes this change? It's really helpful for the developers using Docker-based CI services (e.g. wercker). |
|
@flavorjones echo-ing what @shinnn asked, we're running docker in production and keep getting bitten by this bug, our workaround to downgrade rubygems for just nokogiri is no longer viable due to other deps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletion of these empty directories is flawed on docker with overlayfs, so we better avoid it. The build artifacts are still removed after gem install.
This fixes nokogiri issue #1370 . For further details to the root issue see: moby/moby#19082