fix XML::Reader working with non-existent attributes #1254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nokogiri now bundles a newer libxml, so doesn't have to worry about old bad behavior, and the workaround was broken
|
👍 this fixes the issue i'm having trying to use |
|
Thanks for this PR, tentatively targetting 1.6.8 for it. |
|
Merged manually. Thank you again for this PR and for your amazing patience! This will be in 1.6.8 final. |
flavorjones
added a commit
that referenced
this pull request
May 28, 2016
for reader attribute fix #1254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nokogiri now bundles a newer libxml, so doesn't have to
worry about old bad behavior, and the workaround was broken
without this fix, the test case would return
reader.attribute('other') # => bobapparently picking up the default namespace for any missing attributes