CSS - descendant attribute is parsed incorrectly ("div [bar]")

[jdelStrother]

Hi - I discovered that the CSS parser isn't correctly parsing nameless/classless/idless attribute selectors. I'd expect div [bar] to produce the same xpath as div *[bar], but instead it produces the same xpath as div[bar].

For example:

>> Nokogiri::VERSION
# => "1.6.3.1"
>> Nokogiri::CSS.xpath_for "div [bar]"
# => ["//div[@bar]"]
>> Nokogiri::CSS.xpath_for "div *[bar]"
# => ["//div//*[@bar]"]

I started looking into css/parser.y to try and figure it out, but nothing jumped out at me as obviously incorrect. Any hints?

[knu]

You are right. I hacked up a fix for this, but it's kind of ugly. I'll post a PR later for review.

[knu]

This is a minimum and a bit ugly fix that should work.

@tenderlove Can you come up with a better fix? I couldn't manage to get out of the parser conflict hell last night.

[knu]

I worked out a better one and committed. Hope you can confirm this!

[tenderlove]

@knu nice! Thank you!

[jdelStrother]

Yep, works great for me 👍