From 86652b1587a842baba0a3671f7268bb94ee7fafd Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Wed, 21 Feb 2024 09:20:42 -0500 Subject: [PATCH] dep: update minimum java version from 7 to 8 - Modern OpenJDK (e.g., 21) won't build for Java 7 making development hard - JRuby 9.4 only supports Java 8 and later, and Nokogiri only supports JRuby 9.4+ - Java 7 extended support finally ended in July 2022 - https://support.oracle.com/knowledge/Middleware/2809708_1.html See related commit 08e55603 which updated the minimum to 7 from 6 in 2020 (v1.11.0). --- rakelib/extensions.rake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rakelib/extensions.rake b/rakelib/extensions.rake index cb2881436a..9ca381bc22 100644 --- a/rakelib/extensions.rake +++ b/rakelib/extensions.rake @@ -376,8 +376,8 @@ if java? ext.ext_dir = "ext/java" ext.lib_dir = "lib/nokogiri" - ext.source_version = "1.7" - ext.target_version = "1.7" + ext.source_version = "1.8" + ext.target_version = "1.8" ext.classpath = ext.gem_spec.files.select { |path| File.fnmatch?("**/*.jar", path) }.join(":") ext.debug = true if ENV["JAVA_DEBUG"] end