From 5c1fdf99a346b5f16e194056cc31bf04b33ed8f7 Mon Sep 17 00:00:00 2001 From: Louis Pontoise Date: Sat, 4 Sep 2021 03:10:45 +0900 Subject: [PATCH] fix: some iframes can use about:srcdoc, which spawns popups follow-up to https://github.com/sparkle-project/Sparkle/pull/1586 --- Sparkle/SUWebViewCommon.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sparkle/SUWebViewCommon.m b/Sparkle/SUWebViewCommon.m index 6a9ff64561..325bcf35c5 100644 --- a/Sparkle/SUWebViewCommon.m +++ b/Sparkle/SUWebViewCommon.m @@ -11,7 +11,7 @@ BOOL SUWebViewIsSafeURL(NSURL *url, BOOL *isAboutBlankURL) { NSString *scheme = url.scheme; - BOOL isAboutBlank = [url.absoluteString isEqualToString:@"about:blank"]; + BOOL isAboutBlank = [@[@"about:blank", @"about:srcdoc"] containsObject:url.absoluteString]; BOOL whitelistedSafe = isAboutBlank || [@[@"http", @"https", @"macappstore", @"macappstores", @"itms-apps", @"itms-appss"] containsObject:scheme]; *isAboutBlankURL = isAboutBlank;