From d06b20d6924ae8720620a4db0d7e59d17c4363bd Mon Sep 17 00:00:00 2001 From: David Law Date: Fri, 30 Aug 2024 12:44:21 -0400 Subject: [PATCH 1/2] Logic fix for JP-3689 --- src/stcal/jump/jump.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/stcal/jump/jump.py b/src/stcal/jump/jump.py index 4af4b3831..9eaecf664 100644 --- a/src/stcal/jump/jump.py +++ b/src/stcal/jump/jump.py @@ -972,7 +972,7 @@ def find_faint_extended( first_diffs_masked = np.ma.masked_array(first_diffs, mask=np.isnan(first_diffs)) warnings.filterwarnings("ignore") - if nints > minimum_sigclip_groups: + if nints >= minimum_sigclip_groups: mean, median, stddev = stats.sigma_clipped_stats(first_diffs_masked, sigma=5, axis=0) else: median_diffs = np.nanmedian(first_diffs_masked, axis=(0, 1)) From ac0ae6719c00dcda7a4ff84708576c4dcab76735 Mon Sep 17 00:00:00 2001 From: David Law Date: Fri, 30 Aug 2024 12:47:01 -0400 Subject: [PATCH 2/2] Add change log entry --- changes/285.bugfix.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 changes/285.bugfix.rst diff --git a/changes/285.bugfix.rst b/changes/285.bugfix.rst new file mode 100644 index 000000000..99fb769ab --- /dev/null +++ b/changes/285.bugfix.rst @@ -0,0 +1 @@ +[jump] Fix a logical bug in the jump step for usage of > vs >= per JP-3689.