Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-189: APCORR and ABVEGAOFFSET optional nulls #516

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

PaulHuwe
Copy link
Collaborator

Resolves RAD-189

Closes #488

This PR adds null values to allowed APCORR and ABVEGAOFFSET keyword values.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (f92cfab) to head (a940e46).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #516   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files           4        4           
  Lines         215      215           
=======================================
  Hits          206      206           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulHuwe PaulHuwe marked this pull request as ready for review November 23, 2024 00:52
@PaulHuwe PaulHuwe requested review from WilliamJamieson and a team as code owners November 23, 2024 00:52
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's see if this meets Will's needs.

@PaulHuwe
Copy link
Collaborator Author

PaulHuwe commented Dec 2, 2024

@wcschultz Can you confirm if this if it is what you need?

@wcschultz
Copy link

The changes look good to me. Thanks!

@PaulHuwe PaulHuwe merged commit 48203a1 into spacetelescope:main Dec 2, 2024
12 checks passed
@PaulHuwe PaulHuwe deleted the RAD-189_ApcorrAbvegaNull branch December 2, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APCORR and ABVEGAOFFSET optional nulls
3 participants