Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched logic operators in stcal/jump causing operations error #8647

Closed
stscijgbot-jp opened this issue Jul 15, 2024 · 4 comments
Closed

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3689 was created on JIRA by Tyler Pauly:

During operations reprocessing, a new error was found during detector1 processing of a MIRI TSO dataset, err log attached. It appears that stcal/jump/jump.py checks if nints > minimum_sigclip_groups on L975, then checks if nints >= minimum_sigclip_groups: on L1003.

I don't know the details of how the segment is chunked for multiprocessing, but it appears as though the number of integrations being processed at this point is equal to the cutoff value, leading to an expected parameter instead being undefined. Suggest fixing L975 to >=.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Michael Regan Any thoughts on this?

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Just discussed this with Michael Regan ; solution is to change line 975 to >=.  This is achieved by spacetelescope/stcal#285

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Tyler Pauly on JIRA:

Fixed by spacetelescope/stcal#285

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Confirmed that the now-merged stcal avoids the crash in the file jw03730008001_03101_00001-seg004_mirimage_uncal.fits that originally triggered this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant