Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psf_grid_size keyword is not passed on from ObservationModule to Instrument #92

Closed
york-stsci opened this issue Jul 6, 2020 · 4 comments · Fixed by #99
Closed

psf_grid_size keyword is not passed on from ObservationModule to Instrument #92

york-stsci opened this issue Jul 6, 2020 · 4 comments · Fixed by #99
Assignees
Labels
Milestone

Comments

@york-stsci
Copy link
Collaborator

york-stsci commented Jul 6, 2020

The ObservationModule code does not check its keyword arguments for the new psf_grid_size keyword. This is ported over from documentation issue #81

@york-stsci york-stsci added the Bug label Jul 6, 2020
@york-stsci york-stsci added this to the 1.0.9 milestone Jul 6, 2020
@york-stsci york-stsci self-assigned this Jul 6, 2020
@york-stsci
Copy link
Collaborator Author

I have made a release on my fork of STIPS that has a fix of this issue. NOTE that the psf_grid_size keyword is supplied directly to the ObservationModule, and is not part of the observation (obs) dictionary.

The fix release is at https://github.com/york-stsci/STScI-STIPS-1/releases/tag/v1.0.8-fix1

@benw1
Copy link
Collaborator

benw1 commented Jul 8, 2020

Thanks!
I updated the files in my STScI-STIPS/ directory with these updates, and now stips is hanging on install at MANIFEST.in
l:
(stips) -bash-4.3$ python setup.py install
git submodule command failed unexpectedly:
error: pathspec 'astropy_helpers' did not match any file(s) known to git
Downloading 'astropy-helpers'; run setup.py with the --offline option to force offline installation.
running install
running bdist_egg
running egg_info
writing stips.egg-info/PKG-INFO
writing dependency_links to stips.egg-info/dependency_links.txt
writing entry points to stips.egg-info/entry_points.txt
writing requirements to stips.egg-info/requires.txt
writing top-level names to stips.egg-info/top_level.txt
reading manifest file 'stips.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'

@york-stsci
Copy link
Collaborator Author

There's now a new fix release at https://github.com/york-stsci/STScI-STIPS-1/releases/tag/v1.0.8-fix2

@benw1
Copy link
Collaborator

benw1 commented Aug 10, 2020

This fix worked for me! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants