-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GRPC API for querying the list of members for a given round #236
Add GRPC API for querying the list of members for a given round #236
Conversation
…r-querying-the-list-of-members-for-a-given-round
…r-querying-the-list-of-members-for-a-given-round
…r-querying-the-list-of-members-for-a-given-round
…members-for-a-given-round
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should discuss the design of the ServiceDB
and if we really need the synchronization that is currently built into it. I feel like this is not required since levelDB
is already safe to be used concurrently.
What do you think?
Synchronization for safe concurrent use is absolutely not the point of this design. The point is to decouple the service generating proofs from the consumers of these proofs (and round data). In this design, the IMO it greatly simplifies testing as a consumer is now completely decoupled from the producer. They are connected with a channel only. Take a look at the unit tests. They don't need a mock for the hypothetical "database interface". It avoids creating untestable monsters like the atxBuilder in go-spacemesh where UTs are a mock hell. |
Closes #200.
GetProof()
GRPC doesn't contain a list of members anymore.