Enhancement/NewGlossaryPage #490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spacelab-main ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Alex-dev7
requested changes
Feb 28, 2025
There was a problem hiding this comment.
On mobile or smaller screens can you make the glossary page scroll down more so that the search bar is almost at the top before entering the inner scroll container with the paragraphs. This way there will be more room for the text on the screen (at the moment it is only half of the screen height).
Suggestion: search bar on desktop view seems too wide, a max width should fix it. Move the dropdown closer to the search bar.
Optional: style the scroll bar from default style to something to match the website theme.(can use the same style as the dropdown for the search bar)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated glossary page UI. Went with scroll view on desktop instead of pages. Also replaced individual letter page jumps with ranges instead.