Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost role names and descriptions don't have set standards #34141

Closed
Booblesnoot42 opened this issue Dec 30, 2024 · 1 comment · Fixed by #34155
Closed

Ghost role names and descriptions don't have set standards #34141

Booblesnoot42 opened this issue Dec 30, 2024 · 1 comment · Fixed by #34155
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature

Comments

@Booblesnoot42
Copy link
Contributor

Description

At the moment, there isn't a set standard that ghost role names and/or descriptions follow. For names, many (I think most, but I can't say for sure) use title case ("Smile the Slime", "Rat King", "Closet Skeleton"), while others use sentence case ("Giant spider", Willow the kangaroo", "Space dragon", "Space carp on salvage wreck"). A handful use other schemes, like "Hamlet the hamster." (note the period), "positronic brain", or "Remilia, the chaplain's familiar".

A similar situation exists regarding descriptions, though to a much lesser extent; I've pretty much only seen complete sentences, though I swear I've seen some that don't have ending punctuation.

This lack of consistency obviously has no effect on gameplay, but it can be a bit distracting/grating. As more ghost roles are added, I believe it would be good to have a discussion and set a standard now so that we don't have to do as much work changing things later. The standard would cover casing and use of punctuation for both names and descriptions, as well as any other rules.

Personally, I'm in favor of title case with no punctuation for titles and complete sentences for descriptions; I believe it looks the most "polished," but really it's just personal preference.

@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Dec 30, 2024
@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 31, 2024
@Alpaccalypse
Copy link
Contributor

Alpaccalypse commented Dec 31, 2024

Your two suggested standards seem so sensible, I think it is probably safe to say, that any deviations were probably just an oversight at the time of writing. If I don't see any objections posted here for a while, I'll probably look into this and just make a PR. I agree that it is a small but satisfying thing to standardise.

Edit: I just went ahead and did it, as it seemed so self-evidently a desirable change, with very little wider implications as a potential merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants