You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now in order to display navigation items, you have to override header.inc.html entirely.
Wouldn't it be nice to create a way to inject navigation items to render in the header without overriding the template?
I guess many people need custom branding and override the header anyway, but even then, a list of navigation-items in options.js, that gets rendered inside the template sounds like a sane thing to do.
I've created this feature, looking for feedback before submitting a pull-request. ndelangen@1a4165c
The text was updated successfully, but these errors were encountered:
That's a nice idea, it would fit nicely here. This will allow to keep more standard templates in userland, enabling easier maintenance in future.
As I stated in yesterdays discussion about breadcrumbs #200, it's better to separate templates and fill in the tags with already rendered HTML. It means that you can decompose whole <nav class="source_header_nav"> to another EJS template, which will be (again) configurable through views settings - https://github.com/sourcejs/Source/blob/master/options.js#L92.
Few comments before you do a PR - please don't change the formating of source files and add some docs about the header configuration, probably a new page in /docs will be the best approach.
Right now in order to display navigation items, you have to override header.inc.html entirely.
Wouldn't it be nice to create a way to inject navigation items to render in the header without overriding the template?
I guess many people need custom branding and override the header anyway, but even then, a list of navigation-items in options.js, that gets rendered inside the template sounds like a sane thing to do.
I've created this feature, looking for feedback before submitting a pull-request.
ndelangen@1a4165c
The text was updated successfully, but these errors were encountered: