Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Treat .build_defs and BUILD as Bazel/Starlark files. #8123

Closed
emidoots opened this issue Jan 29, 2020 · 4 comments · Fixed by #10374
Closed

Treat .build_defs and BUILD as Bazel/Starlark files. #8123

emidoots opened this issue Jan 29, 2020 · 4 comments · Fixed by #10374
Assignees
@emidoots
Labels
feature-request stephen-select syntect_server
Milestone
3.16

Comments

@emidoots
Copy link
Member

A customer https://app.hubspot.com/contacts/2762526/company/2174376075/ uses please build which defines BUILD files and .build_defs files in Starlark (Bazel's language). Bazel also uses BUILD files.

Today, we only treat .bzl as Bazel/Starlark files (both in our syntax highlighter and e.g. when using lang:bazel I believe), the ask here is to also treat BUILD and .build_defs files as Bazel/Starlark by default / out of the box.

Ref. https://sourcegraph.atlassian.net/jira/servicedesk/projects/SG/queues/custom/1/SG-25
@emidoots emidoots added this to the Backlog milestone Jan 29, 2020
@emidoots emidoots self-assigned this Jan 29, 2020
@aisbaa
Copy link

aisbaa commented Apr 21, 2020

+1 I also would like to see this implemented.

@emidoots emidoots modified the milestones: Backlog, 3.16 Apr 21, 2020
@emidoots
Copy link
Member Author

Note: also consider .star files https://sourcegraph.slack.com/archives/CTGBWCKM0/p1587456392048500

@emidoots
Copy link
Member Author

Re-prioritized to fix in 3.16 most likely.

emidoots referenced this issue in thedeadtellnotales/Packages Apr 30, 2020
Starlark: update to include more file types
8d523b2 
See https://github.com/sourcegraph/sourcegraph/issues/8123
This was referenced Apr 30, 2020
Merged
Merged
@emidoots
Copy link
Member Author

emidoots commented May 3, 2020

This should be fixed by https://github.com/sourcegraph/sourcegraph/pull/10374 and will be in Sourcegraph 3.16.

@emidoots emidoots closed this as completed May 3, 2020
@emidoots emidoots mentioned this issue May 3, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@emidoots emidoots

Labels
feature-request stephen-select syntect_server
Projects
None yet
Milestone
3.16
2 participants
@aisbaa @emidoots