Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

zoekt: Cleanup failed shards #5300

Closed
keegancsmith opened this issue Aug 19, 2019 · 2 comments
Closed

zoekt: Cleanup failed shards #5300

keegancsmith opened this issue Aug 19, 2019 · 2 comments
Assignees
Milestone

Comments

@keegancsmith
Copy link
Member

On sourcegraph.com we have the OOM killer coming in and killing an index while it is running. A side effect of this is most of the disk space on sourcegraph.com's index-search pod is taken up by half written files. They have a name like:

github.com%2Fzeit%2Fnext.js_v16.00000.zoekt976944826

More generally they match the glob *.zoekt[0-9]*.

A RFC detailing how to tackle this problem should be created. A suggestion I have is using an approach similiar to what we do on gitserver. We use a unique temporary directory per gitserver process. If any other directory matches that directories name on startup, we delete it. This may not be good enough.

@keegancsmith keegancsmith added this to the 3.8 milestone Aug 19, 2019
@tsenart
Copy link
Contributor

tsenart commented Sep 14, 2019

@keegancsmith, @kzh: Is this in the works and in time for 3.8? If not, please change the milestone accordingly.

@kzh kzh modified the milestones: 3.8, 3.9 Sep 15, 2019
@keegancsmith
Copy link
Member Author

@kzh think you will get this in this week? Taking into account time for review/etc so we can land it by Monday.

@kzh kzh closed this as completed Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants