Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chore): Remove all current vulnerability of loopback4-s3 #109

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

Tyagi-Sunny
Copy link
Contributor

@Tyagi-Sunny Tyagi-Sunny commented Feb 16, 2023

Description

remove all current vulnerability of loopback4-s3

Fixes #107

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

dist/types.d.ts Outdated
@@ -11,5 +12,5 @@ export interface AwsS3Config {
region?: string;
}
export declare class S3WithSigner extends S3 {
getSignedUrl(command: PutObjectCommand, options: RequestPresigningArguments): Promise<string>;
getSignedUrl<InputType extends ServiceInputTypes, OutputType extends MetadataBearer = MetadataBearer>(command: Command<InputType, OutputType, any, ServiceInputTypes, MetadataBearer>, options?: RequestPresigningArguments): Promise<string>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why dist files?

remove all current vilnenrability of loopback4-notifications

GH-107
@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yeshamavani yeshamavani changed the title Remove all current vulnerability of loopback4-s3 fix(chore): Remove all current vulnerability of loopback4-s3 Feb 20, 2023
@yeshamavani yeshamavani merged commit b62d089 into master Feb 20, 2023
@yeshamavani yeshamavani deleted the GH-107 branch February 20, 2023 10:26
@sfdevops
Copy link
Contributor

🎉 This PR is included in version 6.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package Update - loopback4-s3
3 participants