Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chore): export mandatory strategies from package #215

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

sf-sahil-jassal
Copy link
Contributor

@sf-sahil-jassal sf-sahil-jassal commented Jan 24, 2024

remove bearer and client password passport strategies type declarations export
and export them from root

GH-214

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #214

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

remove bearer and client password passport strategies type declarations export
and export them from root

GH-214
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sf-sahil-jassal sf-sahil-jassal changed the title fix(chore): remove bearer and client password typeVersions fix(chore): export mandatory strategies from package Jan 30, 2024
@@ -1,3 +1,2 @@
export * from './passport-otp';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since exported from package.json

@yeshamavani yeshamavani merged commit fbd16ad into master Feb 1, 2024
3 checks passed
@yeshamavani yeshamavani deleted the GH-214 branch February 1, 2024 12:53
@yeshamavani
Copy link
Contributor

🎉 This PR is included in version 11.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove bearer and client password typeVersions export
2 participants