Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(provider): make client secret non mandatory for public clients #154

Merged
merged 7 commits into from
Apr 3, 2023
Merged

feat(provider): make client secret non mandatory for public clients #154

merged 7 commits into from
Apr 3, 2023

Conversation

Tyagi-Sunny
Copy link
Contributor

@Tyagi-Sunny Tyagi-Sunny commented Mar 30, 2023 •
edited
Loading

Description

Non blocking changes for making client secret non-mandatory for public clients

Fixes #153

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@yeshamavani
Copy link
Contributor

yeshamavani commented Mar 30, 2023 •
edited
Loading

PR title
also add "overrides": {
"@openapi-contrib/openapi-schema-to-json-schema": "3.2.0"
} in package.json to avoid build errors

sonar code smells

@Tyagi-Sunny
feat(provider): added clientType to auth client
f66e747 
making client secret non mandatory for public clients

GH-153
@Tyagi-Sunny
feat(provider): make client secret non mandatory for public clients
0e51de7 
make client secret non mandatory for publlic clients

GH-153
@Tyagi-Sunny
feat(provider): make client secret non mandatory for public clients
a996951 
make client secret non mandatory for public clients

GH-153
@yeshamavani
Copy link
Contributor

@Tyagi-Sunny the comments above

@Tyagi-Sunny Tyagi-Sunny changed the title Gh 153 feat(provider): added clientType to auth client Mar 31, 2023
@Tyagi-Sunny
feat(provider): make client secret non mandatory for public clients n…
81a5d65 
…on blocking change

make client secret non mandatory for public clients non blocking change

GH-153
@Tyagi-Sunny Tyagi-Sunny changed the title feat(provider): added clientType to auth client feat(provider): make client secret non mandatory for public clients Mar 31, 2023
samarpan-b
samarpan-b requested changes Mar 31, 2023
View reviewed changes
src/component.ts Outdated Show resolved Hide resolved
@Tyagi-Sunny
feat(provider): make single config for secure client
7c634f2 
add securClient config to AuthenticationConifg

GH-153
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@samarpan-b samarpan-b merged commit 039fa8c into master Apr 3, 2023
@samarpan-b samarpan-b deleted the GH-153 branch April 3, 2023 10:35
@sfdevops
Copy link
Contributor

sfdevops commented Apr 4, 2023

🎉 This PR is included in version 7.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeshamavani yeshamavani yeshamavani approved these changes

@samarpan-b samarpan-b samarpan-b approved these changes

@akshatdubeysf akshatdubeysf Awaiting requested review from akshatdubeysf

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modification- Make Client Secret Non Mandatory For Public Clients (Non Blocking Changes)
4 participants
@Tyagi-Sunny @yeshamavani @sfdevops @samarpan-b