-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qrencode -t ANSIUTF8 produces unuseable output [U+2588] #81
Comments
Maybe he dump output is useful?
|
Can you provide the unicode range that this application is using to produce these? |
Only these three:
And Space |
Mind testing this again with the new test build (v2.014). I updated the vertical metrics to be consistent with that in DejaVu Sans Mono/Bitstream Vera Sans Mono/Menlo. This will likely (begin to) address this issue. Test files available in #111 |
Sorry, didn't get a notification. I've tried it, works, with italic, bold and italic bold, but not with regular. |
@m42e Consider clicking the “Subscribe” button in this issue’s sidebar. |
@m42e Can you let us know what you are seeing in the regular set? Will need to know how the spacing is off to address the alignment. Images would be very helpful if possible. |
@jublo I'm subscribed, but somehow missed it. |
No worries. No rush. It seems that the rectangular box glyph width is completely different in the regular set than it is for the square boxes that are positioned on the baseline. |
You can also see the issue, when opening http://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-demo.txt with Hack. At the bottom, there should be increasing bars, but the last element is much smaller than the others. |
Any license on that specimen file? That would be incredibly useful for testing. |
I don't know, it is provided by http://www.cl.cam.ac.uk/%7Emgk25/ but there is no license provided. |
That last box on the lower right corner must be your problem |
Exactly. If I look close you're right, there might be some more issues. |
Thank you. We will create something similar to take a look at these glyphs |
We are modifying the block element glyphs as part of the v2.019 release. Work in progress. May need you to take a look at these qrencode displays again once available if you are free to do so. |
I'll have a look |
@m42e Matthias, can you provide an example of a typeface that does work here? I took a look at the spacing in Source Code Pro and the alignment appears to be further off for these glyphs than what is going on in Hack. I'd be interested in taking a look at the metrics on one that does work for you. I've made changes to the glyphs involved here and they will be released in the upcoming v2.019, likely later this week. |
Ubuntu Mono for Powerline works. It has some space but it is recognized by qr scanners. Hope this helps you. I really appreciate your hard work. |
Thank you very much Matthias. I will take a look. |
If you happen to have some time, could I bother you to give this new build a try? https://github.com/chrissimpkins/Hack/tree/development/postbuild_processing/posthinted_builds The regular set in this build includes glyph modifications that should be getting us closer to where we need to be with this issue. |
Looks good to me :) 👍 Thank you very much. |
vertical spacing OK? |
Yes, ist a very small line, but this is same for all the other fonts I mentioned above. |
Have you come across a font that does not have the lines in between? I am planning to do some work on the hinting to see if I can narrow that further. |
@Defman21 thanks for that screenshot. I really appreciate it. There are definitely size dependent spacing issues that are a result of the hinting. I think that I can get closer to the image appearance that you display across our target font sizes with a bit of manual hinting work. |
You're welcome, thanks for your awesome font! |
Hi,
Another issue with Hack. Using qrencode with ANSIUTF8 output format does not work. Seems the blocks are not compatible.
What I expected:
Thanks
The text was updated successfully, but these errors were encountered: