From cd6758af65b3238f4c0d52ea4eb1f1acd8a60737 Mon Sep 17 00:00:00 2001 From: Javier Gonzalez Date: Tue, 26 Nov 2024 11:06:08 -0500 Subject: [PATCH] release checklist step to compile all python code --- .github/ISSUE_TEMPLATE/release_flight.md | 2 ++ .github/ISSUE_TEMPLATE/release_matlab.md | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/release_flight.md b/.github/ISSUE_TEMPLATE/release_flight.md index 72b11a09..6b1da482 100644 --- a/.github/ISSUE_TEMPLATE/release_flight.md +++ b/.github/ISSUE_TEMPLATE/release_flight.md @@ -20,6 +20,7 @@ assignees: '' - [ ] Promote packages from `masters` to `test` conda channel (`skare3-promote --to test ...`). - [ ] List in PR any data products that need to be promoted to $SKA/data (check PR's interface impacts). - [ ] Install on HEAD and GRETA Linux test environments (`ska3/test`). +- [ ] `python -m compileall $SKA/lib` - [ ] Confirm that test data (SKA/data) is appropriate for release testing (any custom test data is set or previous test data cleaned out) - [ ] Run testr on HEAD and GRETA - [ ] Add related issues to PR (`skare3-milestone-issues ...`). @@ -34,6 +35,7 @@ assignees: '' - [ ] Update ska3/flight on HEAD as aca user. - [ ] Confirm installed versions of ska3-flight and ska3-perl on HEAD with `conda list` - [ ] Update ska3/flight on GRETA as SOT user. +- [ ] `python -m compileall $SKA/lib` - [ ] Confirm installed versions of ska3-flight and ska3-perl on GRETA with `conda list` - [ ] Promote any data products listed in PR to be promoted. - [ ] Run ska_testr on HEAD and GRETA. diff --git a/.github/ISSUE_TEMPLATE/release_matlab.md b/.github/ISSUE_TEMPLATE/release_matlab.md index f6390da3..5871a53b 100644 --- a/.github/ISSUE_TEMPLATE/release_matlab.md +++ b/.github/ISSUE_TEMPLATE/release_matlab.md @@ -26,6 +26,7 @@ assignees: '' - [ ] Notify FOT team of candidate release. - [ ] FOT gives green light to install release candidate. - [ ] Install on GRETA test as SOT user (`ska3/matlab/test`). +- [ ] `python -m compileall $SKA/lib` - [ ] Confirm that test data (SKA/data) is appropriate for release testing (any custom test data is set or previous test data cleaned out) - [ ] FOT tests and approves. - [ ] Promote packages to main conda channel (`skare3-promote ...`). @@ -33,6 +34,7 @@ assignees: '' - [ ] Announce to aca@cfa/slack. - [ ] Update ska3/matlab on cheru as SOT user. +- [ ] `python -m compileall $SKA/lib` - [ ] Make sure $SKA/data is updated on GRETA - [ ] Run ska_testr on cheru. - [ ] Document test results (`skare3-test-dashboard ...`).