Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider how to define mag_err for guide star selection #67

Open
taldcroft opened this issue Sep 9, 2018 · 1 comment
Open

Consider how to define mag_err for guide star selection #67

taldcroft opened this issue Sep 9, 2018 · 1 comment

Comments

@taldcroft
Copy link
Member

taldcroft commented Sep 9, 2018

The current definition of mag_err for a star includes contributions from the catalog mag error plus per-readout error. In some cases for guide stars, e.g. comparing with nearby spoilers, it probably makes more sense to just consider the catalog mag error (i.e. the systematic error on mean mag, not per-readout mag).

This needs more thought but isn't required for the 4.0 release.

@jeanconn
Copy link
Contributor

jeanconn commented Sep 9, 2018

Sure, but it might not be a bad idea to get it reasonable now before we do more rigorous testing. I had pasted in mag_err for use in

  1. the first cut of candidate stars (copying the mag_err < 1.0 filter from ACQ)
  2. the per-stage magnitude filter
  3. The error when comparing a star to its possible spoilers
  4. The error when comparing a star to a possible column spoiler

I think 3 and 4 should revert to MAG_ACA_ERR. 2 is probably OK. 1 could go either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants