Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide star selection tracks imposter mag, but is 'inf' for 0 dark current #196

Closed
jeanconn opened this issue Dec 17, 2018 · 3 comments
Closed

Guide star selection tracks imposter mag, but is 'inf' for 0 dark current #196

jeanconn opened this issue Dec 17, 2018 · 3 comments
Labels
question Further information is requested

Comments

@jeanconn
Copy link
Contributor

For constructed cases the dark map region set to, the count_rate_to_mag(0) gives warning and mag of inf. Is there value in that or should we set the mag to a non-inf value and get rid of the warning?
@jeanconn jeanconn added the question Further information is requested label Dec 17, 2018
@jeanconn
Copy link
Contributor Author

@taldcroft Did you have thoughts on this for the patch release?

@jeanconn
Copy link
Contributor Author

I just set the minimum mag to 20.0 in the end of #195 to avoid all the warnings for the new tests of the fixed extent. If a larger numeric would be appropriate or if "inf" is fine but should get set without a warning, let me know.

@taldcroft
Copy link
Member

Yes on getting this fixed for 4.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@taldcroft @jeanconn