Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide star selection: pixel region not calculated correctly for asymmetric dither #194

Closed
jeanconn opened this issue Dec 14, 2018 · 3 comments
Labels
bug Something isn't working priority-high

Comments

@jeanconn
Copy link
Contributor

These bits in this subroutine should reference "extent" not "row_extent"

rminus = int(np.floor(r - row_extent))

@jeanconn jeanconn added bug Something isn't working priority-high labels Dec 14, 2018
@jeanconn
Copy link
Contributor Author

@taldcroft This is a small population of observations, but I think this should be patched and re-released.

@taldcroft
Copy link
Member

Agreed. The only question is about patch release schedule, if we are releasing for each bug or waiting to see if others are found.

@jeanconn
Copy link
Contributor Author

That was my thought as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-high
Projects
None yet
Development

No branches or pull requests

2 participants