Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for table-generator --static-table #479

Closed
PhilippWendler opened this issue Nov 2, 2019 · 2 comments
Closed

Drop support for table-generator --static-table #479

PhilippWendler opened this issue Nov 2, 2019 · 2 comments
Assignees
@PhilippWendler
Labels
HTML table
Milestone
Release 3.0

Comments

@PhilippWendler
Copy link
Member

After merging support for generating the new dynamic react tables, table-generator can still generate the old kind of HTML tables with --static-table. We should remove this in the next major version if nobody complains.
@PhilippWendler PhilippWendler added this to the Release 3.0 milestone Nov 2, 2019
@PhilippWendler PhilippWendler mentioned this issue Nov 2, 2019
Closed
@dbeyer
Copy link
Member

dbeyer commented Nov 15, 2019

Don't we have extra work with maintaining the code, tests, etc. for the old tables?
Remove immediately? Or is Release 3.0 planned in the near future anyway?

@PhilippWendler
Copy link
Member Author

Tests for old tables have mostly been removed already. Keeping the code is currently holding up some refactoring but not adding extra effort (where we do the refactoring now or in a few weeks/months is not important). Release 3.0 is planned for January.

@PhilippWendler PhilippWendler self-assigned this Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippWendler PhilippWendler

Labels
HTML table
Milestone
Release 3.0
Development

No branches or pull requests
2 participants
@PhilippWendler @dbeyer