Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable customizing serializers #21

Closed
wants to merge 6 commits into from
Closed

Enable customizing serializers #21

wants to merge 6 commits into from

Conversation

sorentwo
Copy link
Owner

Introduces serializer customization. Usage is outlined in the README. Here's a quick summary:

# Set custom serializers
Readthis.serializers << Oj
Readthis.serializers << MessagePack

# Freeze them to prevent further usage
Readthis.serializers.freeze!

# Reset back to the three defaults
Readthis.serializers.reset!

Addresses #18 @fabn

@sorentwo
Introduce serializers wrapper class
b30d785 
Provides a wrapper around a set of serializers with constraints to
prevent breakage.
@sorentwo
Reference modules rather than keys
2ac627f
@sorentwo
Introduce serializers reset
f4eb360 
Useful for reverting back to the defaults, important for globally
testing.
@sorentwo
Provide lookup methods on serializers
647aac9 
Serializers are now used within entities, without knowning about the
internal structure of a serializers instance.
@sorentwo
Add spec to verify custom serializer usage
70866b8
@sorentwo
Add documentation around serializer customization
f6a4487
@fabn
Copy link

fabn commented Sep 17, 2015

Everything look good. Nice job.

@sorentwo
Copy link
Owner Author

Merged into master manually.

@sorentwo sorentwo closed this Sep 18, 2015
@sorentwo sorentwo mentioned this pull request Sep 18, 2015
Closed
@sorentwo sorentwo deleted the customize-serializers branch September 28, 2015 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorentwo @fabn