From 2392f3f5bb9bf1d4d74951c65a05ff1927d74abe Mon Sep 17 00:00:00 2001 From: dgsudharsan Date: Fri, 28 Jun 2024 12:31:16 +0000 Subject: [PATCH 1/2] [DPB]Fix return code in case of failure --- config/main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/main.py b/config/main.py index 89572bd788..0a2776854a 100644 --- a/config/main.py +++ b/config/main.py @@ -4709,7 +4709,7 @@ def breakout(ctx, interface_name, mode, verbose, force_remove_dependencies, load except Exception as e: click.secho("Failed to break out Port. Error: {}".format(str(e)), fg='magenta') - sys.exit(0) + sys.exit(1) def _get_all_mgmtinterface_keys(): """Returns list of strings containing mgmt interface keys From c56bb300e5356c58157cd242496d2a1929d51f9b Mon Sep 17 00:00:00 2001 From: dgsudharsan Date: Fri, 28 Jun 2024 16:32:51 +0000 Subject: [PATCH 2/2] Updating UT --- tests/config_dpb_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/config_dpb_test.py b/tests/config_dpb_test.py index 5dcf814911..0a3d99cbcd 100644 --- a/tests/config_dpb_test.py +++ b/tests/config_dpb_test.py @@ -350,7 +350,7 @@ def test_config_breakout_extra_table_warning(self, breakout_cfg_file, sonic_db): commands["breakout"], ['{}'.format(interface), '{}'.format(newMode), '-v', '-y'], obj=obj) print(result.exit_code, result.output) - assert result.exit_code == 0 + assert result.exit_code == 1 assert 'Below Config can not be verified' in result.output assert 'UNKNOWN_TABLE' in result.output assert 'Do you wish to Continue?' in result.output