Fix review comments

- Handle table name change
- Remove BufferOrch's constructor which isnt used

Signed-off-by: Stephen Sun <stephens@nvidia.com>

Author: stephenxs

cfgmgr/buffer_pool_mellanox.lua

@@ -104,7 +104,7 @@ local statistics = {}
 -- Fetch sizes of all of the profiles, accumulate them
 local accumulative_occupied_buffer = 0
 for i = 1, #profiles, 1 do
-    if profiles[i][1] ~= "BUFFER_PROFILE_KEY_SET" and profiles[i][1] ~= "BUFFER_PROFILE_DEL_SET" then
+    if profiles[i][1] ~= "BUFFER_PROFILE_TABLE_KEY_SET" and profiles[i][1] ~= "BUFFER_PROFILE_TABLE_DEL_SET" then
         local size = tonumber(redis.call('HGET', profiles[i][1], 'size'))
         if size ~= nil then 
             if profiles[i][1] == "BUFFER_PROFILE_TABLE:ingress_lossy_profile" then

cfgmgr/buffermgr.cpp

@@ -258,8 +258,9 @@ void BufferMgr::transformReference(string &name)
  * One thing we need to handle is to transform the separator from | to :
  * The following items contain separator:
  *  - keys of each item
- *  - pool in BUFFER_POOL
+ *  - pool in BUFFER_PROFILE
  *  - profile in BUFFER_PG
+ *  - profile_list in BUFFER_PORT_INGRESS_PROFILE_LIST and BUFFER_PORT_EGRESS_PROFILE_LIST
  */
 void BufferMgr::doBufferTableTask(Consumer &consumer, ProducerStateTable &applTable)
 {

orchagent/bufferorch.cpp

@@ -50,22 +50,6 @@ BufferOrch::BufferOrch(DBConnector *applDb, DBConnector *confDb, DBConnector *st
     initBufferConstants();
 };
 
-BufferOrch::BufferOrch(DBConnector *applDb, DBConnector *confDb, DBConnector *stateDb, vector<TableConnector> &tableConnectors) :
-    Orch(tableConnectors),
-    m_flexCounterDb(new DBConnector("FLEX_COUNTER_DB", 0)),
-    m_flexCounterTable(new ProducerTable(m_flexCounterDb.get(), FLEX_COUNTER_TABLE)),
-    m_flexCounterGroupTable(new ProducerTable(m_flexCounterDb.get(), FLEX_COUNTER_GROUP_TABLE)),
-    m_countersDb(new DBConnector("COUNTERS_DB", 0)),
-    m_countersDbRedisClient(m_countersDb.get()),
-    m_stateBufferMaximumValueTable(stateDb, STATE_BUFFER_MAXIMUM_VALUE_TABLE)
-{
-    SWSS_LOG_ENTER();
-    initTableHandlers();
-    initBufferReadyLists(confDb);
-    initFlexCounterGroupTable();
-    initBufferConstants();
-};
-
 void BufferOrch::initTableHandlers()
 {
     SWSS_LOG_ENTER();
@@ -132,7 +116,7 @@ void BufferOrch::initBufferConstants()
     status = sai_switch_api->get_switch_attribute(gSwitchId, 1, &attr);
     if (status != SAI_STATUS_SUCCESS)
     {
-        SWSS_LOG_ERROR("Failed to get Maxiuum memory size, rv:%d", status);
+        SWSS_LOG_ERROR("Failed to get Maximum memory size, rv:%d", status);
         // This is not a mandatory attribute so in case of failure we just return
         return;
     }

orchagent/bufferorch.h

@@ -33,7 +33,6 @@ class BufferOrch : public Orch
 {
 public:
     BufferOrch(DBConnector *applDb, DBConnector *confDb, DBConnector *stateDb, vector<string> &tableNames);
-    BufferOrch(DBConnector *applDb, DBConnector *confDb, DBConnector *stateDb, vector<TableConnector> &tableConnectors);
     bool isPortReady(const std::string& port_name) const;
     static type_map m_buffer_type_maps;
     void generateBufferPoolWatermarkCounterIdList(void);