[frr-mgmt-framework] "auth_password" in the BGP_NEIGHBOR table cannot be restored correctly

[puffc]

Description

According to the current frrcfgd design, the "auth_password" in the BGP_NEIGHBOR table is converted into the following FRR command:

config_db:

    "BGP_NEIGHBOR": {
        "Vrf1|100.64.1.13": {
            "admin_status": "true",
            "auth_password": "U2FsdGVkX18exaLFN1FUBk3ILAbWxem3VI9MR5IBv7vZ94ppayc8ZtNdBwKajazF",
            "local_asn": 65025,
            "asn": "65020"

bgpd.conf:

...
 neighbor 100.64.1.13 password U2FsdGVkX18exaLFN1FUBk3ILAbWxem3VI9MR5IBv7vZ94ppayc8ZtNdBwKajazF encrypted

However, the generated neighbor password command cannot be restored because the "encrytped" option is not supported by the current version of FRR.
Related PR #5142

Steps to reproduce the issue:

1. Add BGP neighbor and auth_password into the config_db
2. sudo config reload -y
3. The neighbor password is not restored.

Describe the results you received:

Cannot find the neighbor password in the frr running-config.

sonic(config-router)# neighbor 100.64.1.13 password U2FsdGVkX18exaLFN1FUBk3ILAbWxem3VI9MR5IBv7vZ94ppayc8ZtNdBwKajazF encrypted
% Unknown command: neighbor 100.64.1.13 password U2FsdGVkX18exaLFN1FUBk3ILAbWxem3VI9MR5IBv7vZ94ppayc8ZtNdBwKajazF encrypted

Describe the results you expected:

The neighbor password configured in the config_db should be restored.

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

[venkatmahalingam]

@puffc what FRR version was used for this testing 8.5.4?

[puffc]

@puffc what FRR version was used for this testing 8.5.4?

Yes, 8.5.4.

[puffc]

@venkatmahalingam BTW, according to my knowledge, the "encrytped" option can only be used on Broadcom Enterprise SONiC.

[venkatmahalingam]

@puffc Remove encrypted keyword from the below lines as FRR expects the MD5 password by default, we no longer need it.

https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-frr-mgmt-framework/frrcfgd/frrcfgd.py#L1797

https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-frr-mgmt-framework/templates/bgpd/bgpd.conf.db.nbr_or_peer.j2#L47

[puffc]

@puffc Remove encrypted keyword from the below lines as FRR expects the MD5 password by default, we no longer need it.

https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-frr-mgmt-framework/frrcfgd/frrcfgd.py#L1797

https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-frr-mgmt-framework/templates/bgpd/bgpd.conf.db.nbr_or_peer.j2#L47

Thanks! Should I raise a PR to include your recommendation?

[venkatmahalingam]

yes, please, hope this works fine.