Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for ToRRouter #10674

Open
Xichen96 opened this issue Apr 25, 2022 · 4 comments
Open

Add option for ToRRouter #10674

Xichen96 opened this issue Apr 25, 2022 · 4 comments

Comments

@Xichen96
Copy link
Contributor

Description

Currently ToRRouter related features are turned on by finding the string ToRRouter in device type, which caused a problem recently because a ToRRouter device is named MgmtTsToR, which does not contain the string ToRRouter. Several pr has been opened to fix all places where device type is used to determine whether a device is ToRRouter. There should be a new option like is ToRRouter to eliminate this type of problem in the future.

Steps to reproduce the issue:

Describe the results you received:

Describe the results you expected:

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@Blueve
Copy link
Contributor

Blueve commented Apr 26, 2022

Can you link all short-term fix PRs here?

@zhangyanzhao
Copy link
Collaborator

Please go to the release planning

@Xichen96
Copy link
Contributor Author

Xichen96 commented Apr 27, 2022

Can you link all short-term fix PRs here?

These 2 PRs provide short term fix for the problem.

#10375
#10478

@Blueve
Copy link
Contributor

Blueve commented Apr 28, 2022

Please go to the release planning

What do you mean the release planning?
The issue here is to track effort on long-term fix solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants