Skip to content

Commit 8a76e8f

Browse files
[Dell] S6100 - Update EEPROM API serial_number_str to return service tag instead of serial number (#17440)
To modify EEPROM API serial_number_str to return service tag instead of serial number in Dell S6100. Ref PR: #1239 How I did it Update EEPROM API serial_number_str to return service tag instead of serial number. How to verify it Verify decode-syseeprom -s returns service tag in Dell S6100.
1 parent d484f99 commit 8a76e8f

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/chassis.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ def get_serial(self):
207207
Returns:
208208
string: Serial number of chassis
209209
"""
210-
return self._eeprom.serial_str()
210+
return self._eeprom.serial_number_str()
211211

212212
def get_status(self):
213213
"""

platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/eeprom.py

+8-10
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,14 @@ def __init__(self, i2c_line=0, iom_eeprom=False):
7878
self.eeprom_tlv_dict[mac_code] = '00:00:00:00:00:00'
7979

8080
def serial_number_str(self):
81-
(is_valid, results) = self.get_tlv_field(
82-
self.eeprom_data, self._TLV_CODE_SERIAL_NUMBER)
81+
# For Chassis, return service tag instead of serial number
82+
if not self.is_module:
83+
(is_valid, results) = self.get_tlv_field(
84+
self.eeprom_data, self._TLV_CODE_SERVICE_TAG)
85+
else:
86+
(is_valid, results) = self.get_tlv_field(
87+
self.eeprom_data, self._TLV_CODE_SERIAL_NUMBER)
88+
8389
if not is_valid:
8490
return "N/A"
8591

@@ -113,14 +119,6 @@ def part_number_str(self):
113119

114120
return results[2].decode('ascii')
115121

116-
def serial_str(self):
117-
(is_valid, results) = self.get_tlv_field(
118-
self.eeprom_data, self._TLV_CODE_SERVICE_TAG)
119-
if not is_valid:
120-
return "N/A"
121-
122-
return results[2].decode('ascii')
123-
124122
def revision_str(self):
125123
(is_valid, results) = self.get_tlv_field(
126124
self.eeprom_data, self._TLV_CODE_LABEL_REVISION)

platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/module.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ def get_serial(self):
139139
Returns:
140140
string: Serial number of module
141141
"""
142-
return self._eeprom.serial_str()
142+
return self._eeprom.serial_number_str()
143143

144144
def get_status(self):
145145
"""

0 commit comments

Comments
 (0)