Skip to content

Commit 5a4c51a

Browse files
[Dell] S6100 - Update EEPROM API serial_number_str to return service tag instead of serial number (#17440) (#17493)
To modify EEPROM API serial_number_str to return service tag instead of serial number in Dell S6100. Ref PR: #1239 How I did it Update EEPROM API serial_number_str to return service tag instead of serial number. How to verify it Verify decode-syseeprom -s returns service tag in Dell S6100. Co-authored-by: Arun Saravanan Balachandran <52521751+ArunSaravananBalachandran@users.noreply.github.com>
1 parent b278f16 commit 5a4c51a

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/chassis.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ def get_serial(self):
217217
Returns:
218218
string: Serial number of chassis
219219
"""
220-
return self._eeprom.serial_str()
220+
return self._eeprom.serial_number_str()
221221

222222
def get_status(self):
223223
"""

platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/eeprom.py

+8-10
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,14 @@ def __init__(self, i2c_line=0, iom_eeprom=False):
8383
self.eeprom_tlv_dict[mac_code] = '00:00:00:00:00:00'
8484

8585
def serial_number_str(self):
86-
(is_valid, results) = self.get_tlv_field(
87-
self.eeprom_data, self._TLV_CODE_SERIAL_NUMBER)
86+
# For Chassis, return service tag instead of serial number
87+
if not self.is_module:
88+
(is_valid, results) = self.get_tlv_field(
89+
self.eeprom_data, self._TLV_CODE_SERVICE_TAG)
90+
else:
91+
(is_valid, results) = self.get_tlv_field(
92+
self.eeprom_data, self._TLV_CODE_SERIAL_NUMBER)
93+
8894
if not is_valid:
8995
return "N/A"
9096

@@ -118,14 +124,6 @@ def part_number_str(self):
118124

119125
return results[2].decode('ascii')
120126

121-
def serial_str(self):
122-
(is_valid, results) = self.get_tlv_field(
123-
self.eeprom_data, self._TLV_CODE_SERVICE_TAG)
124-
if not is_valid:
125-
return "N/A"
126-
127-
return results[2].decode('ascii')
128-
129127
def revision_str(self):
130128
(is_valid, results) = self.get_tlv_field(
131129
self.eeprom_data, self._TLV_CODE_LABEL_REVISION)

platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/module.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ def get_serial(self):
139139
Returns:
140140
string: Serial number of module
141141
"""
142-
return self._eeprom.serial_str()
142+
return self._eeprom.serial_number_str()
143143

144144
def get_status(self):
145145
"""

0 commit comments

Comments
 (0)