Revise after implementation

Author: superchild

doc/sag/images/sag-flow.png

@@ -30,6 +30,7 @@
 | :---: | :--------- | :---------: | --------------------------------- |
 |  0.1  | 08/13/2021 |  Jimi Chen  | Initial version                   |
 |  0.2  | 08/30/2021 |  Jimi Chen  | Update community review comments  |
+|  0.3  | 10/20/2021 |  Jimi Chen  | Revise after implementation       |
 
 # Scope 
 This HLD extends SONiC to support static anycast gateway
@@ -146,7 +147,7 @@ The format is in the following
 
 ```
 admin@edgecore:~$ sudo config static-anycast-gateway mac_address del -h
-Usage: config static-anycast-gateway mac_address add [OPTIONS] <mac_address>
+Usage: config static-anycast-gateway mac_address del [OPTIONS] <mac_address>
 
   Delete global static-anycast-gateway mac address
 
@@ -247,11 +248,13 @@ Add new yang model to describe static anycast gateway configuration
 ```
 container sonic-static-anycast-gateway {
     container SAG {
-        description "static anycast gateway configuration";
+        container GLOBAL {
+            description "static anycast gateway configuration";
 
-        leaf gwmac {
-            type yang:mac-address;
-        }
+            leaf gwmac {
+                type yang:mac-address;
+            }
+        }        
     }
 }
 
@@ -290,7 +293,7 @@ list VLAN_INTERFACE_LIST {
     }
 
     leaf staic-anycast-gateway {
-        description "Enable/Disable static anycast gateway"
+        description "Enable/disable static anycast gateway for the vlan interface";
         type boolean;
         default false;
     }

doc/sag/sag-HLD.md

@@ -4,7 +4,6 @@ box "Orchagent" #LightGrey
     control IntfMgrD
     control IntfsOrch
     control RouteOrch
-    control VrfOrch
 end box
 participant kernel
 box "DB" #LightBlue
@@ -25,38 +24,22 @@ IntfsOrch <-- APPL_DB
 IntfsOrch -> ASIC_DB: create router interface and change to SAG MAC address
 IntfMgrD -> APPL_DB: config VLAN interface IP
 IntfsOrch <-- APPL_DB
-alt VLAN interface in default VRF
-    IntfsOrch -> RouteOrch: delete system MAC generated IPv6 link-local to me route
-    RouteOrch -> ASIC_DB: remove route entry
+
+loop all existed VRFs
     IntfsOrch -> RouteOrch: add SAG MAC generated IPv6 link-local to me route
     RouteOrch -> ASIC_DB: add route entry
-else VLAN interface in VRF
-    IntfsOrch -> VrfOrch: delete system MAC generated IPv6 link-local to me route
-    VrfOrch -> RouteOrch
-    RouteOrch -> ASIC_DB: remove route entry
-    IntfsOrch -> VrfOrch: add SAG MAC generated IPv6 link-local to me router
-    VrfOrch -> RouteOrch
-    RouteOrch -> ASIC_DB: add route entry
 end
+
 group Disable SAG on the VLAN interface
     UI -> CONFIG_DB: disable SAG on the VLAN interface
     IntfMgrD <-- CONFIG_DB
     IntfMgrD -> kernel: change VLAN interface's MAC address to CPU MAC address
     IntfMgrD -> APPL_DB: Modify INTF_TABLE entry from SAG MAC address to CPU MAC address
     IntfsOrch <-- APPL_DB
     IntfsOrch -> ASIC_DB: change router interface's MAC address to CPU MAC address
-    alt VLAN interface in default VRF
+    loop all existed VRFs
         IntfsOrch -> RouteOrch: delete SAG MAC generated IPv6 link-local to me route
         RouteOrch -> ASIC_DB: remove route entry
-        IntfsOrch -> RouteOrch: add system MAC generated IPv6 link-local to me route
-        RouteOrch -> ASIC_DB: add route entry
-    else VLAN interface in VRF
-        IntfsOrch -> VrfOrch: delete SAG MAC generated IPv6 link-local to me route
-        VrfOrh -> RouteOrch
-        RouteOrch -> ASIC_DB: remove route entry
-        IntfsOrch -> VrfOrch: add system MAC generated IPv6 link-local to me route
-        VrfOrch -> RouteOrch
-        RouteOrch -> ASIC_DB: add route entry
     end
 end
 @enduml