Make caching class return undefined if property does not exist #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhamail
approved these changes
Sep 7, 2021
brent-spiner
pushed a commit
that referenced
this pull request
Sep 7, 2021
## [4.0.31](v4.0.30...v4.0.31) (2021-09-07) ### Bug Fixes * Make caching class return undefined if property does not exist ([#247](#247)) ([8e3b3ad](8e3b3ad)) * use newer node version in CI release process, required to run semantic-release. ([589e0ce](589e0ce)) * use newly published @xmldom/xmldom package. fixes [#243](#243) ([9f8b646](9f8b646))
|
🎉 This PR is included in version 4.0.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am unsure how this broke, but what this PR does is: return
undefinedif a property is set to''inConfig. It's likely we should rethink this class a bit and set those properties as optional, or something akin.This pull request makes the following changes:
src/Config/OssIndexServerConfig.tsto returnundefinedfor properties if they are not setsrc/Config/OssIndexServerConfig.tsto do a better check when setting propertiesIt relates to the following issue #s:
cc @bhamail / @DarthHater / @allenhsieh / @ken-duck