-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of proxy environment variable (#191) #199
Add support of proxy environment variable (#191) #199
Conversation
Thanks for the contribution! Before we can merge this, we need @francois-roget to sign the Sonatype Contributor License Agreement. |
src/Services/RequestHelpers.ts
Outdated
@@ -14,6 +14,8 @@ | |||
* limitations under the License. | |||
*/ | |||
import os from 'os'; | |||
import { Agent } from 'http'; | |||
const HttpsProxyAgent = require('https-proxy-agent'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, can this not be imported like import {HttpsProxyAgent} from 'https-proxy-agent';
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DarthHater the code has been changed as requested.
I made a fixup. If this version is agreed, I'll squash it to have a single commit
@francois-roget one minor question, if you wouldn't mind taking a look! |
Thanks for the contribution! Unfortunately we can't verify if the committer(s), François Roget francois.roget@ingenico.com, signed the CLA because they have not associated their commits with their GitHub user. Please follow these instructions to associate your commits with your GitHub user. Then sign the Sonatype Contributor License Agreement and this Pull Request will be revalidated. |
58a4b96
to
75a5cf3
Compare
@DarthHater I corrected according to your remark. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! thanks for doing this I knew it was one of those little things that would have to be addressed but couldn't get to
* If you are not a Sonatype customer, Do NOT file Sonatype support tickets related to nancy support in regard to this project, file an issue here on GitHub | ||
- If you are a Sonatype customer, you may file Sonatype support tickets related to `AuditJS` support in regard to this project | ||
- We suggest you file issues here on GitHub as well, so that the community can pitch in | ||
- If you are not a Sonatype customer, Do NOT file Sonatype support tickets related to nancy support in regard to this project, file an issue here on GitHub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DarthHater bit of a typo here :P
🎉 This PR is included in version 4.0.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Allow the CLI to take into account http_proxy or https_proxy environment varaibles to perform the network requests. This is particularly handy in corporate CI.
This pull request makes the following changes:
It relates to the following issue #s:
cc @bhamail / @DarthHater / @allenhsieh / @ken-duck