Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonata\Exporter\Handler uses deprecated interface SourceIteratorInterface #552

Closed
jderusse opened this issue Nov 16, 2021 · 1 comment · Fixed by #573
Closed

Sonata\Exporter\Handler uses deprecated interface SourceIteratorInterface #552

jderusse opened this issue Nov 16, 2021 · 1 comment · Fixed by #573

Comments

@jderusse
Copy link

Environment

Sonata packages

show

$ composer show --latest 'sonata-project/*'
Color legend:
- patch or minor release available - update recommended
- major release available - update possible
- up to date version
sonata-project/admin-bundle              4.2.1  4.2.2  The missing Symfony Admin Generator
sonata-project/block-bundle              4.8.0  4.8.0  Symfony SonataBlockBundle
sonata-project/cache                     2.2.0  2.2.0  Cache library
sonata-project/datagrid-bundle           3.4.2  3.4.2  Symfony SonataDatagridBundle
sonata-project/doctrine-extensions       1.15.0 1.15.0 Doctrine2 behavioral extensions
sonata-project/doctrine-orm-admin-bundle 4.1.0  4.1.0  Integrate Doctrine ORM into the SonataAdminBundle
sonata-project/exporter                  2.9.0  2.9.1  Lightweight Exporter library
sonata-project/form-extensions           1.12.1 1.12.1 Symfony form extensions
sonata-project/twig-extensions           1.9.0  1.9.0  Sonata twig extensions

Subject

In #532 the SourceIteratorInterface interface has been deprecated, but the class Sonata\Exporter\Handler still expect an instance of SourceIteratorInterface.

So we don't have any way to fix the deprecation.

@VincentLanglet
Copy link
Member

Do you want to make the PR @jderusse ?
SourceIteratorInterface is deprecated in favor of \Iterator, so changing the typehint to \Iterator would solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants