Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Block does not implement EditableBlockService don't show it in composer #1621

Closed
haivala opened this issue Sep 28, 2022 · 3 comments
Closed
Labels

Comments

@haivala
Copy link
Contributor

haivala commented Sep 28, 2022

Feature Request

If Block does not implement EditableBlockService don't show it in page composer as it only triggers errors.

@haivala
Copy link
Contributor Author

haivala commented Sep 29, 2022

In BlockAdmin the block that does not implement EditableBlockService should be shown but it should be indicated somehow that it cannot be used?

@eerison
Copy link
Contributor

eerison commented Oct 11, 2022

@haivala could you confirm if jordi's PR fixed your issue, if yes could you close?

@haivala
Copy link
Contributor Author

haivala commented Oct 12, 2022

@eerison yes it fixed it!

@jordisala1991 & @VincentLanglet You were taking about the implementation: I think that the "old way" would be still good: Make block maker define block setting that is the block context as an array but this time it would need proper documentation. if it has sonata_page_block then show it in the page composer and BlockAdmin. I'm only aware that there is another context admin that makes sure that the block is only used in SonataAdmin like in the dashboard.

@haivala haivala closed this as completed Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants