Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Rename EmptyFilter to NullFilter #1208

Closed
VincentLanglet opened this issue Nov 18, 2020 · 0 comments · Fixed by #1234
Closed

[RFC] Rename EmptyFilter to NullFilter #1208

VincentLanglet opened this issue Nov 18, 2020 · 0 comments · Fixed by #1234
Labels
feature
Milestone
4.0

Comments

@VincentLanglet
Copy link
Member

Feature Request

Doctrine provide a IS EMPTY and IS NOT EMPTY check
https://www.doctrine-project.org/projects/doctrine-orm/en/latest/reference/dql-doctrine-query-language.html#get-all-users-that-have-no-phonenumber

So the EmptyFilter is misleading, since he's doing a NULL check.
And it avoid us to implement the "real" EmptyFilter.

I think we should

  • Rename EmptyFilter to NullFilter (in a BC way)
  • Remove the EmptyFilter in 4.0
  • Implement the real EmptyFilter in 4.0

WDYT @sonata-project/contributors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Deprecate EmptyFilter in favor of NullFilter pbories/SonataDoctrineORMAdminBundle
1 participant
@VincentLanglet