Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove render button on "Year in pixels" #17

Closed
queze1 opened this issue Jan 17, 2022 · 3 comments
Closed

Remove render button on "Year in pixels" #17

queze1 opened this issue Jan 17, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@queze1
Copy link

queze1 commented Jan 17, 2022

Is your feature request related to a problem? Please describe.
The render button is redundant since rendering only needs to happen when the year is changed or the tab is loaded.

Describe the solution you'd like
Remove the render button and automatically rerender whenever the year is changed.

@queze1 queze1 added the enhancement New feature or request label Jan 17, 2022
@someretical
Copy link
Owner

The render button is there if the user wants to manually change the year. The reason why it is this way is because it's a relatively expensive process to render all the buttons. You can check the source code in src/gui/diarypixels.cpp to see what I mean.

@queze1
Copy link
Author

queze1 commented Jan 17, 2022

Automatically rendering once the user manually changing the year would be more convenient than manually changing the year and pressing the render button.

@someretical
Copy link
Owner

The thing is, you can't just switch to a completely different year without pasting the value in directly. So either you paste it in once and it updates, or it just keeps on updating as you change the place values one by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants