Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for extension/datasets.pyi #4

Closed
Miking98 opened this issue Oct 21, 2022 · 3 comments
Closed

Add documentation for extension/datasets.pyi #4

Miking98 opened this issue Oct 21, 2022 · 3 comments

Comments

@Miking98
Copy link
Collaborator

Would be great to add documentation / type checking for the functions in extension/datasets.pyi since its not immediately obvious what these methods do from the code.

@Miking98
Copy link
Collaborator Author

Also, can we rename Dictionary to be Array or something -- the current name is confusing given its accessed via an integer index into a list of values.

@EthanSteinberg
Copy link
Contributor

The key part of Dictionary is that it also supports fast inverse lookups. I think using the name Array would mask that.

@EthanSteinberg
Copy link
Contributor

We really need python/mypy#13284 to do this right.

@Miking98 Miking98 added this to femr Jan 26, 2023
@Miking98 Miking98 moved this to 🆕 New in femr Jan 26, 2023
@Miking98 Miking98 removed this from femr Jan 26, 2023
@Miking98 Miking98 added this to femr Jan 26, 2023
@Miking98 Miking98 moved this to 🆕 New in femr Jan 26, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in femr Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants