From 58cacde5c43e841eb8f7de9f40b0c4957509cebe Mon Sep 17 00:00:00 2001 From: Sam Heilbron Date: Fri, 30 Jun 2023 10:32:54 -0600 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Bernie Birnbaum --- test/ginkgo/parallel/ports.go | 2 +- test/services/docker.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/ginkgo/parallel/ports.go b/test/ginkgo/parallel/ports.go index 41c1c34416f..855f3a5bdf0 100644 --- a/test/ginkgo/parallel/ports.go +++ b/test/ginkgo/parallel/ports.go @@ -66,7 +66,7 @@ func portInUseDenylist(proposedPort uint32) error { // AdvancePortSafeListen returns a port that is safe to use in parallel tests // It relies on pinging the port to see if it is in use -// This may be slow than using a denylist, but it is more robust +// This may be slower than using a denylist, but it is more robust func AdvancePortSafeListen(p *uint32) uint32 { return AdvancePortSafe(p, portInUseListen) } diff --git a/test/services/docker.go b/test/services/docker.go index 1da7d6e962b..bf49b3b2fae 100644 --- a/test/services/docker.go +++ b/test/services/docker.go @@ -67,7 +67,7 @@ func ExecOnContainer(containerName string, args []string) ([]byte, error) { func MustStopAndRemoveContainer(containerName string) { StopContainer(containerName) - // We assumed that the container was run with auto-remove, and thus stopping the container will cause it to be removed + // We assume that the container was run with auto-remove, and thus stopping the container will cause it to be removed err := WaitUntilContainerRemoved(containerName) Expect(err).ToNot(HaveOccurred())