Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve payment method from the payment source #120

Closed
aldesantis opened this issue Jun 17, 2020 · 1 comment · Fixed by #121
Closed

Retrieve payment method from the payment source #120

aldesantis opened this issue Jun 17, 2020 · 1 comment · Fixed by #121

Comments

@aldesantis
Copy link
Member

aldesantis commented Jun 17, 2020

Currently, the payment method needs to be set via the configuration.

This makes it harder to allow users to subscribe through different payment methods, since it requires monkey-patching the Checkout#active_card method.

Instead, we should retrieve the payment method directly from the payment source that's being charged, which should be easy enough via active_card.payment_method.

This spares the user from having to set the gateway manually and lays the groundwork for #116.

@aldesantis
Copy link
Member Author

Closed via #121.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant