Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime dependency of rails-i18n set in gemspec prevents an update to solidus 2.0 (and rails 5) #85

Closed
bosskovic opened this issue Mar 24, 2017 · 1 comment

Comments

@bosskovic
Copy link
Contributor

Hi, I'm trying to update our app to solidus 2.0 (and rails 5), but a dependency in the gemspec of solidus_i18n seems to be preventing that:

  s.add_runtime_dependency 'rails-i18n', '~> 4.0.1'

Should I make a PR that updates the version, if it's as simple as that?

@tvdeyen
Copy link
Member

tvdeyen commented Mar 24, 2017

Yes, but make sure old versions are still supported. So, best bet is something like:

s.add_runtime_dependency 'rails-i18n', ['>= 4.0.1', '< 6']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants