Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Promo code batch creation with email field #3952

Closed
spaghetticode opened this issue Feb 22, 2021 · 0 comments · Fixed by #3957
Closed

[Admin] Promo code batch creation with email field #3952

spaghetticode opened this issue Feb 22, 2021 · 0 comments · Fixed by #3957

Comments

@spaghetticode
Copy link
Member

In the admin there are 2 ways for creating promotion code batches (Spree::PromotionCodeBatch):

  1. from the new promotions page at the bottom of this partial;
  2. from the edit promotion page, by following the links in the header Promotion Code Batches -> New Promotion Code Batch, see this form

The second way allows to specify an email address where a confirmation email will be sent after the batch have been processed. This does not happen with the first flow.

For consistency, I think we should have the email field also on the first path. Also, if possible I think it would make sense to unify the erb code that handles both pages, so we won't happen to possibly have different behaviors again in the future.

Solidus Version:
master and below

Screenshots

first path second path
Screen Shot 2021-02-22 at 3 01 07 PM Screen Shot 2021-02-22 at 3 02 04 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant