Missing image in autocomplete variant

[sechix]

Trying to add a product variant to an order from admin. If variant don't have images no image appears. It should display master image as in the other parts of solidus.

In this case this can be solved modifying this file : 'assets->javascript->spree->backend->templates->variants->autocomplete.hbs' buy I have detected more handlebars using the same logic.

[jacobherrington]

In Slack @vzqzac brought up:

wouldn’t show the master image misinform the user of the variant being selected? Thinking a bit about UX in here :thinking_face: open to discussion though

I think he has a point, but I also don't expect the people using this page to really understand the difference between a normal variant and a master variant. As long as the SKU is correct, I don't think it would be a bad user experience.

[sechix]

For example, in our case we use the same images always for all variants, so never assign the images to any variant. So if I am looking for a product I have to see the image associated in this case the master because don't have a specific image. This is the normal behavior in solidus. And don't disturb the other case, only add functionality.

[vzqzac]

In the projects I've worked on we have different images for each variant, so I think that showing the master variant's image could lead the user to think they're choosing that variant.

But I think @jacobherrington has a point too, users that can use the admin panel, and add products to orders, might have better knowledge of the application flow and thus rely on SKUs to make sure it's the variant they want.

Still, I think that relying on the master variant could have some UX issues

[sechix]

@vzqzac Only when variant don't show image has to display master image. This is how hows in every part of solidus

[vzqzac]

Right @sechix, we should keep consistency in this case in my opinion, if the way it is showed in this part changes, it should come along with many other places updated, so might be better to keep it as is in the rest of the project