Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature?]: Vite 5 / Rollup 4 support #1123

Closed
2 tasks done
birkskyum opened this issue Nov 16, 2023 · 8 comments
Closed
2 tasks done

[Feature?]: Vite 5 / Rollup 4 support #1123

birkskyum opened this issue Nov 16, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@birkskyum
Copy link
Contributor

birkskyum commented Nov 16, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

Lots of good stuff here:

Vite 5

Rollup 4

Examples 🌈

No response

Motivation 🔦

No response

@birkskyum
Copy link
Contributor Author

birkskyum commented Dec 19, 2023

Blocked by:

@LexSwed
Copy link

LexSwed commented Dec 20, 2023

I assumed that vite 5 support was added here:
620b638

@birkskyum
Copy link
Contributor Author

birkskyum commented Dec 20, 2023

I assumed that vite 5 support was added here: 620b638

that was a first step, fixing simple usage of solidj.js with vite outside of Start, i.e. to make a SPA without a server part. With the 0.4 version of solid start where the dependency graph is start -> vinxi -> vite, it's necessary to update this in vinxi, and maybe adjust some things in start then as well.

@nksaraf
Copy link
Member

nksaraf commented Dec 20, 2023

Yup I had got it working earlier but found some issues in my projects where rollup 5 would choke on some syntax in some old libs.

I will add this back with optional support for falling back to vite 4 via overriding npm/yarn/pnpm resolutions.

@nksaraf
Copy link
Member

nksaraf commented Dec 22, 2023

Added this back in vinxi@0.0.54. I haven't made vite 5 the default, but you can use it by getting your own version of vite using npm/yarn/pnpm resolutions or overrides.

@birkskyum
Copy link
Contributor Author

Thanks!

@nksaraf
Copy link
Member

nksaraf commented Dec 22, 2023

Please confirm if this actually works I haven't tried it out outside my repo

@birkskyum
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants