Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websockets does not check .acl #1334

Open
jaxoncreed opened this issue Oct 30, 2019 · 2 comments
Open

Websockets does not check .acl #1334

jaxoncreed opened this issue Oct 30, 2019 · 2 comments
Assignees
@jaxoncreed

Comments

@jaxoncreed
Copy link
Contributor

From
nodeSolidServer/node-solid-ws#1
inrupt/websockets-pubsub#5

The fix:
https://github.com/inrupt/websockets-pubsub/blob/2c5e097c670a679d2f2072683c88e1216de3a307/src/lib/hub.ts#L76
@jaxoncreed jaxoncreed self-assigned this Oct 30, 2019
@michielbdejong
Copy link
Member

See also https://github.com/solid/specification/issues/52#issuecomment-682491952

@michielbdejong michielbdejong mentioned this issue Nov 5, 2020
Open
@melvincarvalho
Copy link
Contributor

Can I just check to see we are talking about the websockets in:

https://github.com/nodeSolidServer/node-solid-ws

I have tested this now with two fresh apps, and I'm happy to report it's still working very well.

Is the issue that we should do an ACL check on the resource before sending a pub notification? That sounds like it would be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaxoncreed jaxoncreed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@melvincarvalho @michielbdejong @jaxoncreed