Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes while fetching game data #6

Closed
Yoddikko opened this issue Oct 14, 2022 · 6 comments · Fixed by #10
Closed

Crashes while fetching game data #6

Yoddikko opened this issue Oct 14, 2022 · 6 comments · Fixed by #10
Labels
bug Something isn't working steam

Comments

@Yoddikko
Copy link

Game Battlerite Public Test id:427460 not found in Steam store, fetching details from library
AttributeError: 'SteamApp' object has no attribute 'img_logo_url'

@Yoddikko
Copy link
Author

I created a pull requeste where I fix this problem. When you accept it you can also close this issue.

@solesensei solesensei added bug Something isn't working steam labels Oct 28, 2022
@solesensei
Copy link
Owner

In an API GetOwnedGames there is img_logo_url field, but it seams it's missing for your game.

So the code breakes here.

@Yoddikko
Copy link
Author

In an API GetOwnedGames there is img_logo_url field, but it seams it's missing for your game.

So the code breakes here.

I tryed to put a place holder image in case he couldn't retrieve the image. Not knowing Python I wasn't succesful but maybe it could be a fix?

@solesensei
Copy link
Owner

solesensei commented Oct 28, 2022

I fount it, so the field img_logo_url is not required as I thought

@solesensei
Copy link
Owner

I tryed to put a place holder image in case he couldn't retrieve the image. Not knowing Python I wasn't succesful but maybe it could be a fix?

Sure, it can be fixed. I'll take a look at it later this week. You can create PR with your fix. I'll check it later too

@Yoddikko
Copy link
Author

I tryed to put a place holder image in case he couldn't retrieve the image. Not knowing Python I wasn't succesful but maybe it could be a fix?

Sure, it can be fixed. I'll take a look at it later this week. You can create PR with your fix. I'll check it later too

My code didn't work at all sadly. Hoping that you can give look.

Thanks again.

@solesensei solesensei linked a pull request Oct 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working steam
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants