NH-42177 liboboe 12.3.0 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammy-baylis-swi
force-pushed
the
NH-42177-liboboe-12-3-0
branch
from
020a676 to
9c29bc2
Compare
|
Woah, thanks for noting down @tammy-baylis-swi the ERROR level message you're seeing! @jerrytfleung I definitely missed this on review, but it looks like we're logging some of the UAMS Client ID retreival steps at ERROR level by mistake? |
Yes. My bad. Fixed PR is here. https://github.com/librato/solarwinds-apm-liboboe/pull/108 |
|
My bad too!! I reviewed the original PR. Thank you for following up. |
|
Thanks @jerrytfleung and @cheempz for that! Updated to 12.3.1, please let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATED May 31 2023 - Startup logs are quieter now, thank you Jerry! 😺
Upgrade Python APM to liboboe 12.3.1. tox tests pass on this PR. Fresh test traces:
Previous description
Upgrade Python APM to liboboe 12.3.0.
tox tests pass on this PR.
Currently get this log at instrumented app launch:
Unable to open UamsClientId file /opt/solarwinds/uamsclient/var/uamsclientid, error: No such file or directory, user: root [/home/ubuntu/workspace/build-clib-solarwinds-apm/liboboe/util.cpp:207] [liboboe-HostIdService-error p#1.72]Test traces: